ARM: dts: qcom: msm8226-motorola-titan: Enable WiFi and touchscreen - #21
Conversation
4993db4 to
d6a38b3
Compare
daviewales
changed the title
|
Update: Also enabled the touchscreen! Edit: But now it doesn't seem able to stay powered off. (Yes, I'm using the right Edit 2: Interestingly, it powers off fine from a full boot. It only turns back on unexpectedly if I run Edit 3: Ignore the previous two edits... I get the same behaviour without these commits. |
d6a38b3 to
d51b2ed
Compare
| /* WCNSS */ | ||
| regulator-min-microvolt = <750000>; | ||
| regulator-max-microvolt = <1337500>; | ||
| regulator-always-on; |
There was a problem hiding this comment.
regulator-always-on is not a proper solution, pm8226_l3 is already referenced from pronto, if l8 is also needed then the bindings are incomplete. If you have schematics please double-check there.
There was a problem hiding this comment.
I've narrowed this down to just l8 being required.
Looking at downstream, this is the vdd_pronto_pll-supply specified in msm8226.dtsi. Does that mean it belongs in the common upstream qcom-msm8226.dtsi file rather than just in the titan dts?
qcom,pronto@fb21b000 {
compatible = "qcom,pil-pronto";
reg = <0xfb21b000 0x3000>,
<0xfc401700 0x4>,
<0xfd485300 0xc>;
reg-names = "pmu_base", "clk_base", "halt_base";
interrupts = <0 149 1>;
vdd_pronto_pll-supply = <&pm8226_l8>;
(Also, it's not immediately clear to me what upstream property matches this.)
|
I've hopefully fixed most of the synaptics issues in 2b62f49. (Kept as a separate commit for review, but will squash it with the original when you're happy with the changes.) Will work on the |
Enable WiFi for motorola-titan, supported by existing driver for WCN3620. regulator-always-on for l3 and l8 prevents bootloops and instability. Signed-off-by: David Wales <daviewales@disroot.org>
Enable the Synaptics RMI4 I2C touchscreen for motorola-titan. Signed-off-by: David Wales <daviewales@disroot.org>
2b62f49 to
6041c1f
Compare
2 participants
WiFi
regulator-always-on for l3 and l8 prevents bootloops and instability.
Note: the following errors appear in
dmesg, particularly when trying to use Bluetooth and WiFi at the same time. So far as I can tell, this is likely an issue with the driver, not the device tree.In particular,
SMD_EVENT (312)isWCN36XX_HAL_P2P_NOA_ATTR_INDfromwcn36xx/hal.hwhich is not explicitly handled bywcn36xx_smd_rsp_process()inwcn36xx/smd.c.I have no idea how to fix that, and WiFi works great if I don't touch Bluetooth, so figured I should just send this.
(Bluetooth also works, but with a lot more dropouts. I haven't tried Bluetooth with WiFi disabled, but I was able to detect events from a paired PS4 DualShock controller before it dropped out.)
Thanks @erikas9987 for the hint about the regulators!
Touchscreen
Enable the Synaptics RMI4 I2C touchscreen for motorola-titan.